Skip to content

docs: Add documentation comments#585

Merged
rwalworth merged 5 commits intohiero-ledger:mainfrom
freya-docs:add-documentation-comments
Mar 9, 2026
Merged

docs: Add documentation comments#585
rwalworth merged 5 commits intohiero-ledger:mainfrom
freya-docs:add-documentation-comments

Conversation

@freya-docs
Copy link
Contributor

Description:
This PR adds documentation comments to the TransactionHash.swift file.

Related issue(s):

Fixes #538

Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
@freya-docs freya-docs requested a review from a team as a code owner March 8, 2026 21:37
@freya-docs freya-docs requested a review from SimiHunjan March 8, 2026 21:37
Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @freya-docs! The doc comments are a good start, but they need a few adjustments to match the existing documentation style in the codebase. I've left a comment below with the details - once that's addressed, we should be good to go!

@rwalworth rwalworth added the status: needs revision A pull request that requires changes before merge label Mar 9, 2026
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
Signed-off-by: freya-docs <freya.docs.pp@gmail.com>
@freya-docs
Copy link
Contributor Author

@rwalworth Thank you for your feedback! I've changed it as requested.

Copy link
Contributor

@rwalworth rwalworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the doc comments match the codebase style now, thank you @freya-docs! Running the workflows now and will get this merged.

@rwalworth rwalworth added status: needs review The pull request is ready for maintainer review and removed status: needs revision A pull request that requires changes before merge labels Mar 9, 2026
@rwalworth rwalworth merged commit cf2d178 into hiero-ledger:main Mar 9, 2026
11 of 16 checks passed
@rwalworth rwalworth removed the status: needs review The pull request is ready for maintainer review label Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Good First Issue]: Add documentation comments to TransactionHash.swift

2 participants